Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Rename default sheet, also add color helper #319

Merged
merged 10 commits into from
Feb 5, 2024

Conversation

devsdocs
Copy link
Contributor

@devsdocs devsdocs commented Feb 5, 2024

  • Add abilities to remove/rename default sheet name Sheet1
  • Add ExcelColor for helping with coloring on border, font, and cell background

Should fix #309 and #315

@FauconSpartiate
Copy link
Contributor

@devsdocs Could you add some tests for the "Sheet1" part to make sure it stays working as expected?

@devsdocs
Copy link
Contributor Author

devsdocs commented Feb 5, 2024

@FauconSpartiate okay

Copy link
Contributor

@FauconSpartiate FauconSpartiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FauconSpartiate FauconSpartiate merged commit a4f3f38 into justkawal:main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

excel.delete("Sheet1") execute error
2 participants